Skip to content

fix: convert step to int when logging #20830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2025
Merged

fix: convert step to int when logging #20830

merged 1 commit into from
May 16, 2025

Conversation

clumsy
Copy link
Contributor

@clumsy clumsy commented May 15, 2025 •
edited by github-actions bot
Loading

What does this PR do?

Fixes #20692

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20830.org.readthedocs.build/en/20830/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label May 15, 2025
@clumsy
Copy link
Contributor Author

clumsy commented May 15, 2025

Can you please have a look at this, @awaelchli? Thanks!

@Borda Borda changed the title fix: convert step to int when logging (#20692) fix: convert step to int when logging May 16, 2025
@Borda Borda merged commit 3d39824 into Lightning-AI:master May 16, 2025
85 checks passed
@clumsy clumsy deleted the fix/float_step branch May 16, 2025 19:22
Borda pushed a commit that referenced this pull request Jun 19, 2025
@clumsy @Borda
fix: convert step to int when logging (#20830)
431ee9d 
fix: convert step to int when logging (#20692)

Co-authored-by: Alexander Zhipa <[email protected]>

(cherry picked from commit 3d39824)
sudiptob2 pushed a commit to sudiptob2/pytorch-lightning that referenced this pull request Jun 27, 2025
@clumsy @azzhipa @sudiptob2
fix: convert step to int when logging (Lightning-AI#20830)
0211c10 
fix: convert step to int when logging (Lightning-AI#20692)

Co-authored-by: Alexander Zhipa <[email protected]>
@clumsy clumsy mentioned this pull request Aug 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Borda Borda Borda approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

Assignees

No one assigned

Labels

pl Generic label for PyTorch Lightning package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

logger_connector has edge case where step can be a float

3 participants

@clumsy @Borda @azzhipa